Add test for the ability to create resources in YAML for resources without forms

rancher / dashboard

The Rancher UI

https://rancher.com

Apache License 2.0

442 stars 243 forks source link

Add test for the ability to create resources in YAML for resources without forms #5092

Open catherineluse opened 2 years ago

catherineluse commented 2 years ago

Vince mentioned this was a regression. There has already been a fix for this bug, but a test should also be added to prevent another regression. https://github.com/rancher/dashboard/issues/5034

cnotv commented 1 year ago

It's the test intended to aim to this button?

Screenshot 2022-07-28 at 11 49 32

catherineluse commented 1 year ago

No, the request is for testing the UX for resources that don't have any forms for them in the UI. This is usually either because they are obscure, or not recommended to be manually updated, or because they are a custom resource that only some users would have. For example, Leases:

You would basically need to:

confirm that the Create from YAML button exists on the list view for the resource
confirm that you can successfully create the resource from YAML

cnotv commented 1 year ago

I would rather stick to the second case, as the first one is unit test based on client files.

catherineluse commented 1 year ago

The error that caused this issue to be opened was when the Create from Yaml button just didn't show up.

cnotv commented 1 year ago

Yes, but as you can see in the PR, that's something which can be tested inside this component. https://github.com/rancher/dashboard/pull/4997/files