rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
463 stars 261 forks source link

Improve list of resources to delete in PromptRemove #6260

Open richard-cox opened 2 years ago

richard-cox commented 2 years ago

Setup

Describe the bug This is following on from https://github.com/rancher/dashboard/issues/6257 and the discussion in slack (~1st July).

The resource list is currently comma separated, the requirement now is to make the list bullet pointed. Consideration should be given to

To Reproduce Multiple Resources

Single Resources

Screenshots image

Josh-Diamond commented 2 years ago

This looks great. One idea i had, was if we make the bullet point list scrollable, maybe we should not include the Delete button in the scrollable list of clusters, but just have it fixed to the bottom of the modal. This way, if the customers select to delete 1000 clusters, they can simply click the Delete button to confirm, without having to scroll down the list of 1000 clusters to find the delete button.

I also think that a scrollable list is much better than pagination, from a user's perspective

richard-cox commented 1 year ago

General comment. I've seen a modal where they handle this by asking the user to enter <resouce name> and <x> more

richard-cox commented 1 year ago

~Linking this issue to another regarding the generic delete modal - https://github.com/rancher/dashboard/issues/8138~ Misread, that issue bypasses the modal

richard-cox commented 1 year ago

This would be a really nice one to tackle still. I've removed it from 2.7 milestone to get it re-assessed. It also requires UX

richard-cox commented 1 year ago

Should be tackled with https://github.com/rancher/dashboard/issues/9708

valaparthvi commented 1 year ago

General comment. I've seen a modal where they handle this by asking the user to enter <resouce name> and <x> more

I believe I have seen this while deleting multiple GKE clusters in the Google Cloud console, and this is one of the solutions I was thinking of when I opened #9708.