rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
454 stars 257 forks source link

Failed EKS cluster shows Registration page in Cluster details page #6839

Open dasarinaidu opened 2 years ago

dasarinaidu commented 2 years ago

Rancher Server Setup

Information about the Cluster

User Information

Describe the bug

Created an EKS cluster ( api service endpoint marked as PRIVATE ) which was failed due to unavailability of VPCs. At the and it is showing Registration details when user open the cluster

To Reproduce

  1. Create AWS Instance
  2. Provision Rancher
  3. Create a cluster from Rancher. Make sure ( api service endpoint marked as PRIVATE and VPCs option marked as Standard)
  4. Create a cluster
  5. Cluster created and provisioning is failed
  6. Open the cluster and check for the Registration details

Actual Behavior :

  1. It contains all the kubectl commands with Rancher data and IP address on it.
  2. The same behavior by selecting the options PRIVATE/PUBLIC OR BOTH

Note: Attached screen shots by clearing the IP address details

Expected Result Registration page/tab should not be seen

Attached Screenshot:

image
gaktive commented 2 years ago

The logic to hide the Registration tab would be tricky since there could be scenarios where we may accidentally hide it when needed.

This feels like a transitionary state in the midst of waiting for the cluster to come online. Maybe the short answer is to come up with a banner that says "Once provisioning is complete, run the commands below to register" or another visual status. We'd need to repro and understand if this could happen with creation and import.

kwwii commented 1 year ago

We should add another banner above the yellow warning banner in this case that informs the user that the cluster is still in a provisioning state and the commands below should not be run

mantis-toboggan-md commented 8 months ago

This likely ties into discussion on https://github.com/rancher/dashboard/issues/8524