Advanced Filtering Updates

[richard-cox]

This is a container issue for items to address before we expand the application of the new Advanced Filtering list feature

Functional

• Enhancement - Split out Group By from Show Columns. The show/hide columns feature would be pretty handy in a lot of lists
  • 
• Enhancement - Persist show columns settings to be applied over page refresh.
• Bug - Advanced filtering assumes a columns getValue is a function that just returns the property defined in value, this is not the case and the function could return a value not related to a single property.
• Investigation - Advanced Filtering may suffer scaling issues, given how often the columns and rows are iterated through. Given changes during the PR though i think these will be similar to those of the normal filter
• Bug - Advanced filtering by labels do not work for Norman resources where the label is not in metadata.labels (see comment https://github.com/rancher/dashboard/pull/7134#discussion_r996799448)

UX

• Request - Column filterable warning should be moved to the filter context (dropdown)
• Discussion - Discover-ability of the table menu needs improving (i think i recommended this new location, and then forgot and thought the moved group by controls were lost)
• Request - After entering text to filter by hitting return should execute the add button
  • 

[aalves08]

Thanks for compiling all of these @richard-cox 🙇 🙇 🙇 🙇

[aalves08]

@kwwii , @richard-cox has suggested a number of UX/UI improvements for the advanced filtering feature. Imo, this should have some input from the UX team just to consolidate the experience. What do you think? 🙏

[kwwii]

I agree that we should split out the "Group by" functionality. (Should we just remove it for now?)

The 3 dots icon is not enough - even I mistook it for one of the icons in the rows. We should pick a better icon from Material or Eos.

I am not sure about the icon to show which columns are not filterable by. Mainly, I am afraid to start putting icons around things as they seem to add up. I think we need to look into this a bit better and see if there are other alternatives

[aalves08]

Other points to be checked/added:

• check sorting of table by labels
• on long label names, hover to display full string