search

rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
451 stars 257 forks source link

Create icon component with utilities and style guide #7588

Open cnotv opened 1 year ago

cnotv commented 1 year ago

Describe

Given 142 occurrences, utilities and existing style guide, create a component for the icon matching existing criteria and utilities.

Context

It is currently available a list of icons used for Rancher, although we do not display the used sizes within the Dashboard and potentially globally. List of utilities can be found here and range from size to animation and hierarchy.

This lack has been highlighted by issues encountered while dealing with the icons in https://github.com/rancher/dashboard/issues/7496

While creating this component, address existing ones: IconIsDefault (it seems not used but listed in Storybook), and IconText (which also seems not defined).

Screenshot 2023-10-04 at 09 44 09
gaktive commented 1 year ago

Pushing out some Storybook settings out from Q2 to Q3 though as we get closer to the Q2 release and there's time left, we could have EMEA pull in some back in.

cnotv commented 12 months ago

@rak-phillip should we integrate this to the @rancher/components library just as for the buttons?

rak-phillip commented 11 months ago

@cnotv yeah, I think an icon component would be a great candidate. Rancher Desktop suffers from the same problem described above.