vSphere CPI chart does not function properly with vSphere Tags enabled by default

[a-blender]

Setup

• Rancher version: v2.7-head
• Browser type & version: Safari

Describe the bug

The vSphere CPI chart does not function properly with vSphere Tags enabled by default. When you leave vSphere Tags enabled, the CPI chart deploys but the kubelet does not remove taints from the nodes or set the provider ID on the nodes. That in turn, causes the CSI chart deployment to fail because because from the docs, CSI needs the provider ID set on the nodes to work properly.

Both @vivek-infracloud and @slickwarren have seen this.

To Reproduce

• Spin up a docker install of Rancher v2.7-head on a linux node behind the vSphere VPN
• Spin up a downstream cluster
• Set taint node.cloudprovider.kubernetes.io/uninitialized=true:NoSchedule on each node
• Install CPI 1.4.1 with vSphere Tags enabled (default) but no values set for Region or Zone

Install

Taints are not removed from the nodes

Result

CPI malfunctions and CSI cannot be deployed.

Expected Result

CPI and CSI chart should deploy and function successfully.

[a-blender]

I reproduced this issue on v2.7-head in the UI and then deployed CPI 1.4.1 via helm and did not see the issue. Taints were removed and the provider ID was set on the nodes. It appears to be UI specific. IMO this should be fixed in the UI. vSphere Tags should not be enabled by default and if a user enables it, the UI should pass an empty string instead of null (likely what is happening) or require valid values to install.

Test values.yaml

vCenter:
  host: <fremont URL>
  port: <port>
  insecureFlag: true
  clusterId: "ablender-test-cluster-id"
  datacenters: <datacenter>
  username: <username>
  password: <password>

labels:
  region: ""
  zone: ""

[a-blender]

Attached a PR to update docs for now

[a-blender]

Merged PR for docs update. This still needs to be fixed by UI.

[gaktive]

Putting into Backlog so we can talk this with the team first (Next Up indicates that it has been pointed).

@annablender is this needed for the 2023 Q1 release?