search

rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
455 stars 257 forks source link

(SURE-5534) Adding node pools only works for user node pools, not system node pools. #8105

Closed kkaempf closed 1 year ago

kkaempf commented 1 year ago

https://jira.suse.com/browse/SURE-5534

A nice to have issue for AKS - Adding node pools only works for user node pools, not system node pools.

Request description: A user needs a feature for adding system node pools in AKS, not only user node pools

Actual behavior: An admin is able to add node pools in AKS that are labeled as User node pools, however unable to add system node pools with rancher tools.

Expected behavior: Deploying node pools as needed for whatever AKS demands in it's infrastructure for features in AKS

Additional notes:

https://learn.microsoft.com/en-us/azure/aks/use-system-pools?tabs=azure-cli

This is scoped to AKS only

@nwmac has a PR up already.

mjura commented 1 year ago

This is limited only by UI and not operator, aks-operator supports creation of multiple System Node Pools

Josh-Diamond commented 1 year ago

n/a

Josh-Diamond commented 1 year ago

No initial issues seen w/ first round of testing, but inability to update maxSurge value is blocking further testing.

Will resume testing, once concerns w.r.t. maxSurge have been addressed

Josh-Diamond commented 1 year ago

Ticket #8105 - Test Results - ✅

Full test plan with detailed steps available internally upon request.

Scenario Test Case Result
1. Provision downstream AKS w/ user configured "system" mode nodepools on Rancher v2.7-head ✅
2. Provision downstream AKS on v2.7.3 => upgrade Rancher to v2.7-head => verify system mode node pool feature is implemented and accessible, post rancher-server upgrade ✅
3. Create AKS cluster in Azure portal => Import AKS cluster into Rancher v2.7-head => verify system mode node pool feature is implemented and accessible for imported clusters ✅