rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
441 stars 243 forks source link

Automation: Auth Provider config page contains bad code block #8818

Open gaktive opened 1 year ago

gaktive commented 1 year ago

Based on work done in https://github.com/rancher/dashboard/issues/7737, let's write an automated test to ensure that the code block for admin fits inline. This could be expanded (if it's quick) to ensure our styling in code blocks looks OK but we can focus on the Auth Providers first.

To reproduce:

Expected result is not this: 208128171-7fdeee57-6a6c-4ea2-84af-f0bac62ff0ca.png

cnotv commented 1 year ago

Just to don't get this lost in the air @gaktive, we should handle these types of tests with some visual tests.

Components like this one should be added to Storybook and reviewed there. The code also has 5 repetitions which should have been clearly converted in a prop of the Banner component, then reviewed within Storybook.

If we have visual tests and the style guide is reviewed, changes would be hard to be missed.

gaktive commented 1 year ago

@cnotv thanks. If more tests are needed on that front, please file tickets for tracking those as tech debt.

gaktive commented 1 year ago

This should be considered a child ticket for an eventual test suite for visual effects. This likely will be in Storybook.