fix cluster fail

[fmoral2]

Proposed Changes

• this change to only destroy cluster if destroy is true

Types of Changes

Testing

Checklist:

1. If your PR changes anything on or related to Jenkins, run it pointing to your branch to make sure it's okay.

2. Verify code lint; we should not have errors.

3. Update the documentation if needed.

4. Update makefile and docker run if adding new tests.

5. Run your tests at least 4 times with all configurations needed and possible.

6. If needed test with different os types.

Linked Issues

Further Comments

[fmoral2]

this needs to go after https://github.com/rancher/distros-test-framework/pull/116

thats why its failing CI

[mdrahman-suse]

Needs rebasing and linter error fixes

[fmoral2]

ah the CI check failed it. I think maybe the best thing to do here is actually move the createcluster logic to a BeforeSuite, and remove this destroycluster block altogether. That way, it will run the AfterSuite of destroy if the create cluster fails

• this was failing due to a circular dependency, i have fixed using logger directly instead calling it from shared

[mdrahman-suse]

ah the CI check failed it. I think maybe the best thing to do here is actually move the createcluster logic to a BeforeSuite, and remove this destroycluster block altogether. That way, it will run the AfterSuite of destroy if the create cluster fails

• this was failing due to a circular dependency, i have fixed using logger directly instead calling it from shared

I think we should standardize using logger instead of shared lib to make it simple and reduce errors

[fmoral2]

@mdrahman-suse sorry i had push a change not supposed to be pushed, i was only testing a cmd for k3s etcd