feat: add Aws sdk - Githubissues

rancher / distros-test-framework

5 stars 9 forks source link

feat: add Aws sdk #44

Closed fmoral2 closed 11 months ago

fmoral2 commented 11 months ago

Proposed Changes

Add Aws sdk abstraction methods for create and delete instances
Refactor and improvements related

Types of Changes

Testing

Checklist:

If your PR changes anything on or related to Jenkins, run it pointing to your branch to make sure it's okay.

n/a
1. Verify code lint; we should not have errors.
ok
1. Update the documentation if needed.
ok
1. Update makefile and docker run if adding new tests.

-n/a

Run your tests at least 4 times with all configurations needed and possible.
- ok
If needed test with different os types.

-n/a

Linked Issues

Further Comments

fmoral2 commented 11 months ago

LGTM, thank you this is great!

i needed to fix a typo, sorry!

mdrahman-suse commented 11 months ago

We should move out the file refactoring code to a separate PR

aganesh-suse commented 11 months ago

The ProductConfig to Product variable/struct naming related change, EnvConfig() related change, changing the BasePath references/paths/calls... are all not relevant to AWS. Such changes are distracting from the actual changes that are needed. These could potentially be a refactor PR in itself. Please note that the PR review cycle will be much simpler/shorter, once we start getting only relevant changes into a particular PR.

fmoral2 commented 11 months ago

The ProductConfig to Product variable/struct naming related change, EnvConfig() related change, changing the BasePath references/paths/calls... are all not relevant to AWS. Such changes are distracting from the actual changes that are needed. These could potentially be a refactor PR in itself. Please note that the PR review cycle will be much simpler/shorter, once we start getting only relevant changes into a particular PR.

almost all of this were comments from people that i was addressing.