search

rancher / distros-test-framework

5 stars 9 forks source link

fix for rhel error #48

Closed aganesh-suse closed 11 months ago

aganesh-suse commented 11 months ago

Proposed Changes

fix for the rhel error

changing "rhel" to "rhel" - so in other cases, the disable cloud setup service etc dont execute.

Types of Changes

minor script changes for bug fix

Testing

Checklist:

  1. If your PR changes anything on or related to Jenkins, run it pointing to your branch to make sure it's okay. will do soon

  2. Verify code lint; we should not have errors. done

  3. Update the documentation if needed. n/a

  4. Update makefile and docker run if adding new tests. n/a

  5. Run your tests at least 4 times with all configurations needed and possible. will do

  6. If needed test with different os types. will do

Linked Issues

Further Comments

aganesh-suse commented 11 months ago

So in this case we have to just pass rhel or centos8 directly now? We can't do rhel8 any longer?

no we can - it just wont run the disable cloud section if we give rhel8 i believe. for ex: rke2 rocky - rhel8 - wont need this section run. @fmoral2 please feel free to correct me if am wrong.

fmoral2 commented 11 months ago

So in this case we have to just pass rhel or centos8 directly now? We can't do rhel8 any longer?

please look at the jenkins jobs on slack!

we are just disabling cloud setup only when its needed (. OSs. node_os == rhel and centos8) all other node_os names dont need/cant disable it.

rancher-max commented 11 months ago

I believe those jobs used amis that already had it disabled. It still needs to be disabled for all rhel setups. The issue here is that passing just rhel will also then force this to call the rhel7 specific stuff:

  if [ "$node_os" = "rhel" ]
    then
      subscription-manager register --auto-attach --username="$username" --password="$password"
      subscription-manager repos --enable=rhel-7-server-extras-rpms
  fi

which is not what we want for rhel8+

fmoral2 commented 11 months ago

I believe those jobs used amis that already had it disabled. It still needs to be disabled for all rhel setups. The issue here is that passing just rhel will also then force this to call the rhel7 specific stuff:

  if [ "$node_os" = "rhel" ]
    then
      subscription-manager register --auto-attach --username="$username" --password="$password"
      subscription-manager repos --enable=rhel-7-server-extras-rpms
  fi

which is not what we want for rhel8+

i have tested with other images, the images from job it was me adding i also tested locally with other ones but should we gather more amis and test it ? it would be nice