Closed mdrahman-suse closed 7 months ago
@fmoral2 @ShylajaDevadiga I think I have addressed all the comments, please review
very nice job!!! can we have a jenkins job passing for k3s and rke2 before merge ? @mdrahman-suse
very nice job!!! can we have a jenkins job passing for k3s and rke2 before merge ? @mdrahman-suse
Sure will update shortly
Proposed Changes
Types of Changes
Testing
Checklist:
If your PR changes anything on or related to Jenkins, run it pointing to your branch to make sure it's okay.
Verify code lint; we should not have errors.
Update the documentation if needed.
Update makefile and docker run if adding new tests.
Run your tests at least 4 times with all configurations needed and possible.
If needed test with different os types.
Linked Issues
https://github.com/rancher/qa-tasks/issues/882
Further Comments