rancher / dynamiclistener

Apache License 2.0
17 stars 61 forks source link

Allow for default expiration days to be loaded from env #46

Closed nickgerace closed 3 years ago

nickgerace commented 3 years ago

This PR enables the consumer of dynamiclistener's cert generation to specify the number of days until expiration via ENV VAR. By default, not supplying the ENV VAR will result in the same behavior as before. The ENV VAR is optional and specifying will override the default. If any issues occur, we will fallback to the default value.

Partially resolves: https://github.com/rancher/rancher/issues/35366

nickgerace commented 3 years ago

I cannot assign reviewers, so for visibility: this PR is awaiting review from @thedadams