search

rancher / dynamiclistener

Apache License 2.0
17 stars 61 forks source link

Cherry-pick commits that allow setting certificate expiration date #54

Closed maxsokolovsky closed 2 years ago

maxsokolovsky commented 2 years ago

Related to https://github.com/rancher/rancher/issues/35068. This back-ports a few commits that allow to specify the webhook's certificate expiration date in days and, by default, set the certificate's expiration date to 10 years after creation.

maxsokolovsky commented 2 years ago

When this is merged, we will cherry-pick from master branch a few relevant commits in the rancher-webhook itself (for branch release/v0.1) and update its dynamiclistener dependency version.

maxsokolovsky commented 2 years ago

@cmurphy, you're right! I didn't know about that flag, will use it in the future. What do we do with this one though – should I redo the cherry-picking/reopen the PR, or is it OK just this once?

brandond commented 2 years ago

Good catch. I would recommend redoing with git cherry-pick -x . No need to reopen the PR, just hard reset your branch back to the original upstream commit, then cherry-pick and force-push.