search

rancher / ecm-distro-tools

Apache License 2.0
9 stars 27 forks source link

Create a GH action or some other automation workflow to validate that the go.mod files do not have RC tags for Rancher products/projects #251

Open deniseschannon opened 1 year ago

deniseschannon commented 1 year ago

In a given release, before releasing, we want to ensure all references/dependencies are bumped to the latest GA version (non-RC) as well as that no branches are pointing to "dev-v2.x".

Automate validating that the list of dependencies do not have any RC references.

Here is the list of files to check: https://github.com/rancher/rancher/blob/release/v2.8/Dockerfile.dapper https://github.com/rancher/rancher/blob/release/v2.8/package/Dockerfile https://github.com/rancher/rancher/blob/release/v2.8/pkg/settings/setting.go https://github.com/rancher/rancher/blob/release/v2.8/go.mod https://github.com/rancher/rancher/blob/release/v2.8/pkg/apis/go.mod https://github.com/rancher/rancher/blob/release/v2.8/scripts/package-env

briandowns commented 1 year ago

This would probably be best as a Github action. Will need to investigate the best place to trigger this.

deniseschannon commented 1 year ago

Based on the feedback from the recent release captain, this is the most painful step in the final RC validation checkpoints, so I would like this to be done ASAP.

johnatasr commented 1 year ago

Analysis started

deniseschannon commented 1 year ago

@johnatasr @briandowns Are these PRs ready for review? In 2.7.7, there was missed references, so the sooner we automate this step, the better.

Please feel free to run the check on release/v2.7 as it should be clean, but release/v2.8 should have a bunch of RC and dev-v2.8 references.

johnatasr commented 1 year ago

@deniseschannon, this automation is almost complete for each version. I'm currently running the final test and seeking approvals for my PRs. One crucial aspect to note is that this action only indicates the presence of 'dev-' dependencies and release candidate (rc) tags within the specified list of files, and it will determine whether the step passes or fails accordingly.

johnatasr commented 1 year ago

@deniseschannon @briandowns tests finished, prs opened ready for review !

EDIT - Doing some changes to be align with the efforts from this improvement https://github.com/rancher/rancher/pull/42000

johnatasr commented 1 year ago

More updates, I need to do more changes to be in conformance with build vars feature coming in version v2.8 as discussed here, while the PR for version v2.7 is totally ready for review.

deniseschannon commented 11 months ago

We may want to investigate how to fix this issue instead: https://github.com/rancher/ecm-distro-tools/issues/291