search

rancher / elemental-operator

The Elemental operator is responsible for managing the OS versions and maintaining a machine inventory to assist with edge or baremetal installations.
Apache License 2.0
40 stars 17 forks source link

Block reinstall if crds are still pending to be deleted #784

Closed davidcassany closed 2 months ago

davidcassany commented 2 months ago

With #775 reinstalling elemental-operator with helm results in a broken installation. This change is to prevent reinstalling CRDs if there are still instances pending to be deleted.

This will prevent from having silently broken installations. This is the same issue as in #515

davidcassany commented 2 months ago

For full reference other approaches were considered at a time by having some pre-delete hook to run a cleanup logic https://github.com/rancher/elemental-operator/pull/536 This could be an option to try to automate cleanup of an uninstalling operation, feels a bit hacky and error prone, I would not consider it for now, referencing it here in case we need it. In such case the current PR would still be needed as a sanity check.