search

rancher / elemental-toolkit

:snowflake: The toolkit to build, ship and maintain cloud-init driven Linux derivatives based on container images
https://rancher.github.io/elemental-toolkit/docs/
Apache License 2.0
282 stars 49 forks source link

Review and document supported yip keys #2107

Closed kkaempf closed 6 days ago

davidcassany commented 1 week ago

I don't think we need additional documentation for the time being as all keys are documented in yip project README and this properly linked in our docs in Cloud-config reference section.

In the scope of this issue the modules plugin got removed rancher/yip#98.

I wonder if we should do the same for the git and download plugins. They both should be relatively simple to script with simple shell commands and they depend on third party libraries. I think they provide nice features, but I am not sure the additional dependencies for those is worth. Any thoughts?

The entities plugins are also questionable in IMHO (see rancher/yip#81), but those definitely require implementing an alternative and some proper testing, a regression in that front would be pretty bad.

kkaempf commented 1 week ago

👍🏻 on dropping git and download if their dependencies are rather huge and/or unmaintained. :-1: on dropping anything that can be scripted, but has minimal and well maintained dependencies.

davidcassany commented 6 days ago

I think they both can stay. git is relaying on a well maintained library (go-git) and download is based on a small library (grab) which does not depend on anything else.

Closing this issue as I think a yip maintenance is done for now and docs are available and up to date.