search

rancher / elemental-ui

Rancher UI Plugin for Elemental
Apache License 2.0
12 stars 12 forks source link

Include btrfs snapshotter in UI defaults #168

Closed davidcassany closed 7 months ago

davidcassany commented 7 months ago

In addition this commit also changes few other defaults such as reboot: true instead of poweroff and also enables reset.

This makes it easier to test and experiment elemental when quickly trying it out from the UI.

Part of rancher/elemental#1241

davidcassany commented 7 months ago

@aalves08 we'd like to introduce few little changes with the UI defaults of the MachineRegistration. I mostly created this PR to showcase the sort of changes, but have no clue if this is PR itself is actually correct or not or if it needs any further change than that.

Also the other problem we have here is that these defaults are only compatible with elemental-operator >= 1.5.0. Do we have an strategy constraint the next UI version for elemental-operator >= 1.50? This is also a problem for the RAW image story, building RAW images should not be possible with older elemental-operators.

davidcassany commented 7 months ago

There's this warning in the console about 299 - unknown field "spec.config.elemental.install.snapshotter" which comes from the API/backend, but that's probably because I might be using an outdated operator version or something... If the resource is up to your needs in terms of configuration, I wouldn't worry too much about this.

In fact this is happening because you are using an elemental-operator < 1.5.0 This feature has just been merged upstream and only present in our Dev environment for the time being.

davidcassany commented 7 months ago

@aalves08 I consider this ready to be merged (if it actually passes your review 😉).