search

rancher / elemental-ui

Rancher UI Plugin for Elemental
Apache License 2.0
12 stars 12 forks source link

`Machine Inventories` shows the bulk `Actions` dropdown item by default instead of it being expanded #4

Open markusewalker opened 2 years ago

markusewalker commented 2 years ago

Setup

Describe the bug

When a machine inventory is created, here is the current view in the Machine Inventories tab:

image

As soon as you select an inventory item, the Actions dropdown menu is expanded as seen below:

image

Deselecting the inventory item gives the below expected view

image

The issue here is that the default view SHOULD NOT have the Actions dropdown as the first screen capture show. When first viewing the Machine Inventories tab, you should see all of the Actions dropdown divided up as the third screen capture shows. Rancher UI typically will have the Actions bulk item shown when minimizing the browser as shown below:

image

To provide consistency, we need to ensure that OS Management follows the same practices that we see throughout the Rancher UI.

To Reproduce

  1. Setup Rancher and navigate to OS Management > Machine Inventories.
    • If needed, ensure that you have a test machine registration and test machine inventory previously set up.
  2. Navigate to Cluster Explorer > OS Management > Machine Inventories.
  3. Note that the Actions bulk dropdown is present by default.
  4. Select the test machine inventory item and see that the bulk dropdown is expanded.
  5. Deselect the test machine inventory item and see that the expanded actions remain.

Result Machine Inventories is showing the Actions bulk dropdown by default.

Expected Result

Machine Inventories SHOULD NOT show the Actions bulk dropdown by default.

kwwii commented 2 years ago

I think this is a bug in the component handling the buttons at the top left of tables and might be reported elsewhere (? I can't seem to find it ?). IIRC there are pages in which the width of the button(s) causes them to collapse to the Actions dropdown even when the dropdown is wider than the button, or there is only one button.

aalves08 commented 2 years ago

This is not an Elemental issue per-se, but a general rancher/dashboard issue as the component belongs to rancher/dashboard.