rancher / fleet

Deploy workloads from Git to large fleets of Kubernetes clusters
https://fleet.rancher.io/
Apache License 2.0
1.5k stars 226 forks source link

Keep schemebuilder type #2524

Closed manno closed 3 months ago

manno commented 3 months ago

Refers to https://github.com/rancher/rancher/pull/45271 and https://github.com/rancher/fleet/pull/2377

rancher/rancher and rancher/shepherd are expecting SchemeBuilder to be a apimachinery.SchemeBuilder, we want to use the one from controller runtime internally. Embedding the c-r code, so consumers don't inherit the controller-runtime dependency from our API pkg. Hasn't changed for years.