Closed manno closed 3 months ago
Do we want tests for this, eg. integration tests? This would help us detect any regression here.
We would need another git repo, so we have one with a submodule. I though about adding fleet-example to fleet-test-data, but that would increase the clone time for all tests 🤷 I guess, I could argue the actual cloning is done by go-git and our unit tests make sure we pass the right parameter to go-git.
the actual cloning is done by go-git and our unit tests make sure we pass the right parameter to go-git.
This is good enough for me :+1:
Refers to https://github.com/rancher/fleet/issues/2492
Pull request content for Rancher QA verification.
Additional QA
Problem
Since switching to go-git, Fleet would no longer clone submodules.
Solution
According to the go-git documentation this is how to enable submodule cloning.
Testing
Engineering Testing
Manual Testing
Tested with fleet-test-data submodule in https://github.com/manno/fleet-experiments
Automated Testing
QA Testing Considerations
We would need another repo like rancher/fleet-test-data to include as a submodule.
Regressions Considerations
Too many nested repos are a problem for performance.