rancher / fleet

Deploy workloads from Git to large fleets of Kubernetes clusters
https://fleet.rancher.io/
Apache License 2.0
1.47k stars 216 forks source link

Old fleet-crd chart in fleet-system #2578

Open gulecroc opened 8 months ago

gulecroc commented 8 months ago

Rancher Server Setup

Information about the Cluster

User Information

Describe the bug When checking deprecated API whith kubent, I find old fleet CRD :

$ kubent
8:59AM INF >>> Kube No Trouble `kubent` <<<
8:59AM INF version 0.7.0 (git sha d1bb4e5fd6550b533b2013671aa8419d923ee042)
8:59AM INF Initializing collectors and retrieving data
8:59AM INF Target K8s version is 1.26.8
8:59AM INF Retrieved 60 resources from collector name=Cluster
8:59AM WRN failed to discover supported resources for apiextensions.k8s.io/v1beta1: the server could not find the requested resource
8:59AM WRN failed to discover supported resources for apiextensions.k8s.io/v1beta1: the server could not find the requested resource
8:59AM WRN failed to discover supported resources for apiextensions.k8s.io/v1beta1: the server could not find the requested resource
8:59AM WRN failed to discover supported resources for apiextensions.k8s.io/v1beta1: the server could not find the requested resource
8:59AM WRN failed to discover supported resources for apiextensions.k8s.io/v1beta1: the server could not find the requested resource
8:59AM WRN failed to discover supported resources for apiextensions.k8s.io/v1beta1: the server could not find the requested resource
8:59AM WRN failed to discover supported resources for apiextensions.k8s.io/v1beta1: the server could not find the requested resource
8:59AM WRN failed to discover supported resources for apiextensions.k8s.io/v1beta1: the server could not find the requested resource
8:59AM WRN failed to discover supported resources for apiextensions.k8s.io/v1beta1: the server could not find the requested resource
8:59AM WRN failed to discover supported resources for apiextensions.k8s.io/v1beta1: the server could not find the requested resource
8:59AM WRN failed to discover supported resources for apiextensions.k8s.io/v1beta1: the server could not find the requested resource
8:59AM INF Retrieved 244 resources from collector name="Helm v3"
8:59AM INF Loaded ruleset name=custom.rego.tmpl
8:59AM INF Loaded ruleset name=deprecated-1-16.rego
8:59AM INF Loaded ruleset name=deprecated-1-22.rego
8:59AM INF Loaded ruleset name=deprecated-1-25.rego
8:59AM INF Loaded ruleset name=deprecated-1-26.rego
8:59AM INF Loaded ruleset name=deprecated-future.rego
__________________________________________________________________________________________
>>> Deprecated APIs removed in 1.22 <<<
------------------------------------------------------------------------------------------
KIND                       NAMESPACE     NAME                                        API_VERSION                         REPLACE_WITH (SINCE)
ClusterRoleBinding         <undefined>   cattle-admin-binding                        rbac.authorization.k8s.io/v1beta1   rbac.authorization.k8s.io/v1 (1.8.0)
CustomResourceDefinition   <undefined>   bundledeployments.fleet.cattle.io           apiextensions.k8s.io/v1beta1        apiextensions.k8s.io/v1 (1.16.0)
CustomResourceDefinition   <undefined>   bundlenamespacemappings.fleet.cattle.io     apiextensions.k8s.io/v1beta1        apiextensions.k8s.io/v1 (1.16.0)
CustomResourceDefinition   <undefined>   bundles.fleet.cattle.io                     apiextensions.k8s.io/v1beta1        apiextensions.k8s.io/v1 (1.16.0)
CustomResourceDefinition   <undefined>   clustergroups.fleet.cattle.io               apiextensions.k8s.io/v1beta1        apiextensions.k8s.io/v1 (1.16.0)
CustomResourceDefinition   <undefined>   clusterregistrations.fleet.cattle.io        apiextensions.k8s.io/v1beta1        apiextensions.k8s.io/v1 (1.16.0)
CustomResourceDefinition   <undefined>   clusterregistrationtokens.fleet.cattle.io   apiextensions.k8s.io/v1beta1        apiextensions.k8s.io/v1 (1.16.0)
CustomResourceDefinition   <undefined>   clusters.fleet.cattle.io                    apiextensions.k8s.io/v1beta1        apiextensions.k8s.io/v1 (1.16.0)
CustomResourceDefinition   <undefined>   contents.fleet.cattle.io                    apiextensions.k8s.io/v1beta1        apiextensions.k8s.io/v1 (1.16.0)
CustomResourceDefinition   <undefined>   gitjobs.gitjob.cattle.io                    apiextensions.k8s.io/v1beta1        apiextensions.k8s.io/v1 (1.16.0)
CustomResourceDefinition   <undefined>   gitreporestrictions.fleet.cattle.io         apiextensions.k8s.io/v1beta1        apiextensions.k8s.io/v1 (1.16.0)
CustomResourceDefinition   <undefined>   gitrepos.fleet.cattle.io                    apiextensions.k8s.io/v1beta1        apiextensions.k8s.io/v1 (1.16.0)

After investigation, fleet-crd is installed with Helm Chart in two namespace :

image

Kubent show deprecated API because of the old fleet-crd helm installation values stored in secret.

I don't kown in which rancher version the fleet installation changed from fleet-system to cattle-fleet-system.

Is it safe to remove fleet-crd in fleet-system namespace ?

To Reproduce

Result

Expected Result

Screenshots

Additional context

skanakal commented 7 months ago

Its updated in rancher-2.6 onwards... see this: https://github.com/rancher/fleet/issues/395

gulecroc commented 5 days ago

Hi @skanakal , is it possible to move this issue to fleet project ? Thank you