search

rancher / hull

Keep your Helm charts afloat with comprehensive testing
Apache License 2.0
4 stars 5 forks source link

Bump helm to v3.14.1 #43

Closed vardhaman22 closed 8 months ago

vardhaman22 commented 8 months ago

  1. bump helm to v3.14.1 and go to 1.21

  2. fixes an issue with helm change in v3.14.1 till helm v3.13.x engine initialization was based on config: ref and because of that the check to create engine's lookup func pass in case of nil config. but in helm v3.14.x clientprovider is introduced and the clientProvider is not nil even if we pass nil config. ref and then the check is also modified and now relies on the clientprovider. So if we initialize Engine using New function with nil config it will cause this lookup function to be used even though the config is nil now. Which can cause issues while rendering templates. That's why replaced the constructor call with type initialization.

  3. bump golangci-lint to v1.54.0

recena commented 8 months ago

@vardhaman22 Any chance to get this PR merged?

vardhaman22 commented 8 months ago

@vardhaman22 Any chance to get this PR merged?

@recena @adamkpickering has a ticket open for the access to merge in this repo. Once that is done we can merge.