rancher / k3k

Kubernetes in Kubernetes
Apache License 2.0
131 stars 21 forks source link

k3kcli reports version as 'k3kcli version dev (HEAD)' #108

Open kastl-ars opened 1 month ago

kastl-ars commented 1 month ago

I am packaging the k3kcli for openSUSE and noticed that the version output is broken.

This also happens when downloading the latest release, e.g. https://github.com/rancher/k3k/releases/download/v0.2.1/k3kcli.

$ wget https://github.com/rancher/k3k/releases/download/v0.2.1/k3kcli
[...]
$ chmod +x k3kcli
$ ./k3kcli --version
k3kcli version dev (HEAD)

I daresay that the ldflags are not setting the right parameters to overwrite the hardcoded default values. https://github.com/rancher/k3k/blob/main/cli/main.go#L13

Kind Regards Johannes