search

rancher / k3os

Purpose-built OS for Kubernetes, fully managed by Kubernetes.
https://k3os.io
Apache License 2.0
3.5k stars 397 forks source link

install.sh: get_url never fails #721

Closed ghost closed 2 years ago

ghost commented 3 years ago

Since c9144ab9da8cad85c52553469b7005c1adb31823, install.sh will swallow errors after attempts have run out, leading to misleading errors down the line (e.g. mount complaining about missing loop device)

philomory commented 2 years ago

As an example of the kind of error this can lead to, if you've got a custom ISO that sets the k3os.install.config_url kernel parameter in grub.conf, and that URL is inaccessible when booting from the ISO, the k3os install process will just proceed without a config.yaml file eventually, rather than aborting. This leads to an installation that appears successful, but which is essentially unusable, because there's no password or SSH keys so you have no way to log in.