rancher / k3os

Purpose-built OS for Kubernetes, fully managed by Kubernetes.
https://k3os.io
Apache License 2.0
3.5k stars 397 forks source link

Add control-plane toleration to system-upgrade-controller. #745

Closed rawlink closed 2 years ago

rawlink commented 2 years ago

Description

The system upgrade controller manifests only specify a toleration for the deprecated node-role.kubernetes.io/control-plane=true:NoSchedule taint. I run my clusters with the newer node-role.kubernetes.io/control-plane=true:NoSchedule taint but I have to manually patch the system-upgrade-controller manifests for it to run with the newer control-plane taint.

Changes

Testing

Tested manifest changes in k3os kubernetes clusters -- system-upgrade-controller runs correctly in clusters with node-role.kubernetes.io/control-plane=true:NoSchedule taint on controller nodes. Also tested v0.7.5 deploys and starts up correctly.

dweomer commented 2 years ago

@rawlink thank you for this. Can you also bump SUC to 0.7.5 please?

rawlink commented 2 years ago

@dweomer Bumped SUC version to v0.7.5. Everything seems to be running fine in my dev cluster.