rancher / k3os

Purpose-built OS for Kubernetes, fully managed by Kubernetes.
https://k3os.io
Apache License 2.0
3.5k stars 401 forks source link

Cloud-init file should be validated before starting install #793

Open suniljoshi137 opened 2 years ago

suniljoshi137 commented 2 years ago

Is your feature request related to a problem? Please describe. No

Describe the solution you'd like During k3os install, after supplying cloud-init file location (mostly BMC/console doesn't support copy/paste) so it has to be entered manually, so if the path to cloud-init file is not correct, it complains after the installation has started (and fail). Only option at that time is to redo.

Describe alternatives you've considered Would be nice if cloud-init file location can be validated (like wget and error at the same time so it can be corrected right there)

philomory commented 2 years ago

I'd also like to see, during a silent install (with the k3os.install.silent=true and k3os.install.config_url=<some url> kernel parameters set), if the install process fails to fetch the specified URL, it should simply halt without installing anything and display an error to the console. At present, it instead completes the installation but with an empty configuration.