rancher / k3os

Purpose-built OS for Kubernetes, fully managed by Kubernetes.
https://k3os.io
Apache License 2.0
3.5k stars 396 forks source link

When k3os.install.silent=true and no k3os.install.config_url is provided set (default) value to /k3os/system/config.yaml #806

Open carlocorradini opened 2 years ago

carlocorradini commented 2 years ago

Is your feature request related to a problem? Please describe. When setting the kernel cmdline parameter k3os.install.silent=true it ensures that no questions will be asked. Very useful when automatic inastallation/configuration is needed. Therefore, a valid config.yaml file (from url or file path) is required to correctly set up the system. Note that k3os.install.config_url must be always provided otherwise install.sh will fail with exit status 1.

I have my config.yaml in the standard location at /k3os/system/config.yaml. Currently if I set up k3os.install.silent=true I have also to provide k3os.install.config_url=/k3os/system/config.yaml which is very redundant. I think that if k3os.install.silent=true we must also check if k3os.install.config_url is set otherwise use default path /k3os/system/config.yaml.

Describe the solution you'd like When k3os.install.silent=true we also check if k3os.install.config_url is set otherwise use the default path /k3os/system/config.yaml. With this solution I have to set only k3os.install.silent=true and not also k3os.install.config_url.

Additional context I think that this little "fix" should be super easy but unfortunately I'm not a shell expert. That's why I have not already created a pull request.