search

rancher / k3os

Purpose-built OS for Kubernetes, fully managed by Kubernetes.
https://k3os.io
Apache License 2.0
3.5k stars 401 forks source link

Support for silent installation with a default device #809

Closed carlocorradini closed 2 years ago

carlocorradini commented 2 years ago

This pull request aims to fix the following issues: rancher/k3os#807 rancher/k3os#205

Currently, if the installation is silent with k3os.install.silent=true you are forced to also set k3os.install.device. This behavior is not documented in the current README.

I think that setting only k3os.install.silent=true without a device could be very useful (not only for my case). The device is set to the first one available, simple as that.

Of course, setting both silent with a specific device is still supported.

liyimeng commented 2 years ago

This sound dangerous behaviour, it can accidentally erase valuable data, e.g. sda is not alway point to the same disk on each boot ...