search

rancher / kubewarden-ui

Kubewarden's User Interface
Apache License 2.0
11 stars 13 forks source link

Initial defaults chart version tied to controller appVersion #724

Closed jordojordo closed 2 months ago

jordojordo commented 3 months ago

Fix #721

The kubewarden-defaults chart install banner was not tied to the installed kubewarden-controller appVersion, in order to make this work I restructured the methods used in the Dashboard component into utilities and added a method for finding the compatible defaults chart based on the installed controller's appVersion.

https://github.com/rancher/kubewarden-ui/assets/40806497/39ccf533-9927-4966-ae42-3840ca730812

jordojordo commented 2 months ago

@kravciak I wasn't able to reproduce this, but I added a condition to the banner dependent on the loading state, and to the chart install button to not show unless a compatible chart is found.

kravciak commented 2 months ago

Now I get error in console on refresh (Install Defaults button is not visible)

fetch.client.js:79 Error in fetch(): TypeError: Cannot read properties of undefined (reading 'cluster/schemaFor')
    at o (kubewardenController.ts:9:14)
    at a.fetch (DefaultsBanner.vue:38:1)
    at a.<anonymous> (fetch.client.js:76:31)
    at p (regeneratorRuntime.js:44:17)
    at Generator.<anonymous> (regeneratorRuntime.js:125:22)
    at Generator.next (regeneratorRuntime.js:69:21)
    at r (asyncToGenerator.js:3:20)
    at s (asyncToGenerator.js:22:9)
    at asyncToGenerator.js:27:7
    at new Promise (<anonymous>)
jordojordo commented 2 months ago

This might be a timing issue. I can revisit this in a later issue.