Closed visokoo closed 1 month ago
@derekbit, anything else I need to do here or are we good to merge?
@derekbit, anything else I need to do here or are we good to merge?
No. I've merged it. It will be included in v0.0.27 released at the end of this May. Thank you.
Piggybacking off this PR request from @runningman84: https://github.com/rancher/local-path-provisioner/pull/393 but retained the
selector.matchLabels
piece since it's not an immutable field after the release has been deployed and will actually block helm upgrades after the fact.In addition to fixing the duplicate labels, this also adds the ability to add k8s resource requests/limits to the
busybox
helper-pod that's launched.Tested this change locally in my environment and it's deploying and upgrading as expected with this flux
HelmRelease
manifest: