search

rancher / local-path-provisioner

Dynamically provisioning persistent local storage with Kubernetes
Apache License 2.0
2.18k stars 451 forks source link

e2e tests racy? #415

Open jan-g opened 3 months ago

jan-g commented 3 months ago

It looks to me like it's possible for the deleteKustomizeDeployment helper to tear down the local-path-provisioner before it has a chance to clean up associated PVs (with "Delete" reclaim policy).

This can lead to tests spuriously failing because the PV name associated with a current test may or may not sort earlier than pre-existing tests: this can cause the typeCheckCmd to fail since it examines the wrong PV.

jan-g commented 3 months ago

This stabilises the e2e tests when I run locally: https://github.com/rancher/local-path-provisioner/pull/416

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

jan-g commented 1 month ago

PR is acailable for this