search

rancher / local-path-provisioner

Dynamically provisioning persistent local storage with Kubernetes
Apache License 2.0
2.26k stars 454 forks source link

Enable leader election #440

Open applike-ss opened 4 months ago

applike-ss commented 4 months ago

Hello,

it would be great if the leader election could be enabled, so that we can drive an HA setup for local-path-provisioner. Currently if i set the replica count to 3 all 3 pods are trying to manage the same pvc that i create. That is not ideal and might lead to issues with race conditions.

derekbit commented 2 months ago

@applike-ss Sounds good, but, currently, I don't have too much time for the feature. It would be great if you could contribute the feature.

applike-ss commented 2 months ago

If I'm not completely wrong, wouldn't you only need to set this to true? https://github.com/rancher/local-path-provisioner/blob/59a15da27280a4a487a8755d0e5d12ad4a84dbc1/main.go#L269

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

applike-ss commented 3 weeks ago

/unstale

applike-ss commented 3 weeks ago

pls unstale