search

rancher / old-vm

(OBSOLETE) Package and Run Virtual Machines as Docker Containers
Apache License 2.0
646 stars 133 forks source link

Using custom VM images is currently impossible #104

Open trenton42 opened 6 years ago

trenton42 commented 6 years ago

The VM controller always prefixes images with vm.Spec.MachineImage (defined as the constant rancher/vm-%s). This prevents the use of custom machine images.

https://github.com/rancher/vm/blob/62fde3566e8ed2822d514dc9bc9c9a184f249608/pkg/common/constants.go#L11

https://github.com/rancher/vm/blob/f0b2f2cd700f7273ea9f6ccb10ca4f05a4130779/pkg/controller/vm/util.go#L71

Also, the UI has the sample images hard-coded, and depends on the convention above

https://github.com/LLParse/longhorn-ui/blob/748012e17124d95a41efb290ddfb111550b55d1b/src/routes/instances/CreateInstance.js#L98-L106