search

rancher / old-vm

(OBSOLETE) Package and Run Virtual Machines as Docker Containers
Apache License 2.0
645 stars 133 forks source link

Remove vm-base docker image, in prefer to use VM image as lower layer #78

Closed yasker closed 6 years ago

yasker commented 8 years ago

It's much easier to update only startvm script when we're adding more feature/bug fixes to it. The VM image itself is relative stable. It's waste of time to push the same VM image to Docker hub if it's not changed.

So now I remove the vm-base container, and use --build-arg parameter of docker build to include VM image instead. This will put VM image at lower layer of container, and it won't be upload if image itself doesn't changed.

LLParse commented 6 years ago

Closing due to age. We've since adopted build args and images are FROM scratch.