search

rancher / os

Tiny Linux distro that runs the entire OS as Docker containers
https://rancher.com/docs/os/v1.x/en/
Apache License 2.0
6.44k stars 656 forks source link

Support merging of multiple cloud-init datasources #1536

Open janeczku opened 7 years ago

janeczku commented 7 years ago

Currently when the cloud_init.datasources configuration array contains multiple sources (eg. multiple of file or url) only the first available source is ever applied by the cloud-init service.

The desired behavior is that multiple available datasources should be merged into the config. See also: http://cloudinit.readthedocs.io/en/latest/topics/merging.html

SvenDowideit commented 7 years ago

if there's a merge failure / url failure, then we're going to fail out. - but looking at #1538

janeczku commented 7 years ago

@SvenDowideit Need to sync on the merge behavior. E.g. multiple cloud-configs that are setting the same string key or array key.

SvenDowideit commented 7 years ago

@janeczku yup - for the short term, tell me what you want to have happen, and if I have time, I'll add configurability

SvenDowideit commented 7 years ago

I'm going to assume that we can have only one (successful) metadata source, and thus we're only merging #cloud-config and #compose sources.