search

rancher / os

Tiny Linux distro that runs the entire OS as Docker containers
https://rancher.com/docs/os/v1.x/en/
Apache License 2.0
6.45k stars 659 forks source link

Hardcoded option for logging drivers(really awful) #1811

Open ketchoop opened 7 years ago

ketchoop commented 7 years ago

RancherOS Version: (ros os version) v.1.0.0

Where are you running RancherOS? (docker-machine, AWS, GCE, baremetal, etc.)

Parallels 6

With gelf driver max-file opt is passed that are not supported by gelf-driver. Now we can't use any log driver, instead of JSON-driver and standard driver, of course.

Part of my config:

rancher:
...
  docker:
    log_driver: gelf
    log_opts:
      gelf-address: "udp://logstash.service.x:12201"

Docker daemon log:

Command "daemon" is deprecated, and will be removed in Docker 1.16. Please run `dockerd` directly.
Failed to set log opts: unknown log opt "max-file" for gelf log driver
ketchoop commented 7 years ago

Fixed it with

docker:
    log_driver: gelf
    log_opts:
      max-file: ''
      max-size: ''
      gelf-address: "udp://logstash.service.x:12201"

that is, I think, is not the best way. I think, it should be in the docs about dockerd, because this behaviour is not expected at all.

SvenDowideit commented 7 years ago

ug. reopening - I need to do some work on logging

SvenDowideit commented 7 years ago

see #1850 for similar UX issues in the settings