rancher / os

Tiny Linux distro that runs the entire OS as Docker containers
https://rancher.com/docs/os/v1.x/en/
Apache License 2.0
6.45k stars 657 forks source link

ZFS 0.8.0 #2788

Open TBK opened 5 years ago

TBK commented 5 years ago

Please upgrade ZFS to 0.8.0 so we can get Direct IO - https://github.com/zfsonlinux/zfs/releases/tag/zfs-0.8.0

Kernel patch for fpu - https://lkml.org/lkml/2019/5/22/8

niusmallnan commented 5 years ago

Has this patch been merged into the upstream?

TBK commented 5 years ago

No and maintainer do not want to https://lkml.org/lkml/2019/5/22/233

niusmallnan commented 5 years ago

So you expect zfs 0.8.0 and fpu patch to be added to RancherOS. However, we can only support zfs 0.8.0 in the future, we can't merge the patch that is not accepted by the community.

TBK commented 5 years ago

Distros are starting to adopt the patch: https://www.phoronix.com/scan.php?page=news_item&px=ZFS-On-Linux-0.8-Released https://www.phoronix.com/scan.php?page=news_item&px=NixOS-Linux-5.0-ZFS-FPU-Drop

zimme commented 4 years ago

So it appears as though ZoL worked around the SIMD issues so if we wait for another release of ZoL this commit should be included and I don't believe a patch for the kernel is needed.

zimme commented 4 years ago

I have a branch here which builds zfs 0.8.2 fine with the new setup where SPL is included in the zfs tar. However when I try and run the command it complains about GLIBC 2.28 is missing. Not sure if it's the zfs container or the zfs-tools container that needs updating. I'm thinking it's zfs tools that needs updating to a later version of ubuntu it seems as Bionic has glibc 2.27.

zimme commented 4 years ago

It seems as though once the following PR, https://github.com/zfsonlinux/zfs/pull/9515, is merged and a release is cut with that included there should be no blocker from the ZoL side and it's just the glibc thing that needs resolving before zfs 0.8+ will work properly on rancheros.

zimme commented 4 years ago

Hopefully there will be a ZoL 0.8.3 release soon-ish based on the fact that this PR (https://github.com/zfsonlinux/zfs/pull/9776) is present.

@niusmallnan any thoughts on the glibc thing I ran into?

I have a branch here which builds zfs 0.8.2 fine with the new setup where SPL is included in the zfs tar. However when I try and run the command it complains about GLIBC 2.28 is missing. Not sure if it's the zfs container or the zfs-tools container that needs updating. I'm thinking it's zfs tools that needs updating to a later version of ubuntu it seems as Bionic has glibc 2.27.

TBK commented 4 years ago

0.8.3 just dropped - https://github.com/zfsonlinux/zfs/releases/tag/zfs-0.8.3

brotherdust commented 4 years ago

I have a branch here which builds zfs 0.8.2 fine with the new setup where SPL is included in the zfs tar. However when I try and run the command it complains about GLIBC 2.28 is missing. Not sure if it's the zfs container or the zfs-tools container that needs updating. I'm thinking it's zfs tools that needs updating to a later version of ubuntu it seems as Bionic has glibc 2.27.

@zimme The documentation doesn't make it clear exactly how to build system services like this. Can you please describe how to upgrade to this version of ZFS that you've provided in the referenced branch?

zimme commented 4 years ago

As I haven't setup a webrepository for my rancheros install I just clone my os-services repo to my host and just use system-docker to build the zfs image tagging it with the currently running tag of zfs.

It's not the "correct" way of doing it but works for me when I'm jist testing things out like this

brotherdust commented 4 years ago

@zimme Ok. I'll give it a shot. Thanks!

neerdoc commented 4 years ago

Any timetable on this? I'm moving from FreeBSD and have a rather large pool I do not want to recreate from scratch, but I can't import it (in rw, read-only works) in rancher due to a missing feature: _com.delphix:spacemapv2

Google seems to believe an update to ZoL >0.8.1 should do the trick...