rancher / prometheus-federator

Apache License 2.0
9 stars 21 forks source link

Fix base64 command in scripts/build-chart to provide -i explicitly to work on Macs #28

Closed aiyengar2 closed 1 year ago

aiyengar2 commented 1 year ago

Issue: https://github.com/rancher/prometheus-federator/issues/29

Problem

Running ./scripts/build on a Mac results in an error due to the base64 command not explicitly providing the filename as -i, instead relying on positional arguments.

Solution

Explicitly pass in -i. Works within a Docker container as well (verified by the fact that the Dapper build is passing).

Testing

Ran it locally

Versioning

For Community Members or Maintainers Making Changes

Please checkmark one of the boxes below to indicate you have following the versioning guidelines for rancher-project-monitoring:

Note: We do not use RC versions for rancher-project-monitoring since it is hidden anyways and not intended for standalone use

Please checkmark one of the boxes below to indicate that you have followed the versioning guidelines for prometheus-federator:

For Maintainers Releasing The Chart On QA Validation

Please checkmark both of the boxes below to indicate that you have followed the versioning guidelines for prometheus-federator:

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations