rancher / quickstart

380 stars 335 forks source link

Change allow all to allow my IP #176

Closed Ipswitch closed 2 years ago

Ipswitch commented 3 years ago

Limits access to the instance to reduce attack surface area. Adds result of whatsismyip.sh to the TF. Requires jq to be installed.

Increased instance storage size.

bashofmann commented 2 years ago

First of all, thank you for your contribution. While I understand the idea behind the change, unfortunately we can't merge this.

Of course, you oftentimes want to have firewall rules and restrictions like this. But, the terraform modules in this repo are meant to be for evaluation and demonstration purposes only. As such they should work in all kinds of environments.

This change would create multiple problems: