rancher / quickstart

380 stars 335 forks source link

Add scaleway provider to the examples #177

Closed mig4ng closed 2 years ago

mig4ng commented 3 years ago

Why

I wanted to try this quickstart at Scaleway and it was not one of the examples. There is one PR (https://github.com/rancher/quickstart/pull/123) open for this but it was WIP and using an outdated version of scaleway/scaleway terraform provider.

What changed (to help with review)

I based it in the DigitalOcean example because they clouds and terraform providers are very similar.

Changes:

Also changed the README and the terraform.yml github workflow.

Tests

Tested it and the rancher server and a RKE example workload cluster started properly and everything seems to be working as expected.

Screenshots

Scaleway instances Rancher clusters global view

bashofmann commented 2 years ago

Thank you for the contribution, and sorry for the long reaction time. The PR looks good and works.

Since there have been quite a few changes in the mean time, I rebased your changes on master and opened up a new PR.

Closing in favour of #197.