search

rancher / quickstart

382 stars 342 forks source link

Fixed data providers vars #39

Closed ianwesterfield closed 5 years ago

ianwesterfield commented 5 years ago

Fixes #38 by adding = to each instance of vars { for AWS and DO data providers. Reference: https://www.terraform.io/docs/providers/template/index.html

Also removes a superfluous configuration in the digitalocean_droplet DO resource.

ananth-racherla commented 5 years ago

@slamkalukas see https://github.com/rancher/quickstart/pull/40 if you are trying to run against aws

ianwesterfield commented 5 years ago

@slamkalukas I didn’t try against AWS, however I ran into the same issue trying with DO. The changes in this PR did correct those allowing me to successfully run the script.

slamkalukas commented 5 years ago

@ianwesterfield thanks, it looks working (i cannot test it properly because of another error - but at least terraform plan is fine)

superseb commented 5 years ago

Thanks for the PR, either this or #40 needs to be updated using terraform 0.12upgrade to include all changes needed for Terraform 0.12, if either is updated I can merge. Thanks

ianwesterfield commented 5 years ago

I’m good, thanks. The changes you require are beyond the scope of this ticket.