rancher / quickstart

382 stars 342 forks source link

[AWS] Configure the provider credentials with a profile #60

Closed dkeightley closed 4 years ago

dkeightley commented 4 years ago

The default ~/.aws/credentials file is often configured to store credentials (access/secret keys) for AWS CLI and SDK use. With that, to simplify the aws quickstart, these can be leveraged in the provider opposed to configuring these manually in a .tfvars file.

Example:

 provider "aws" {
  region = var.aws_region
}
nikkelma commented 4 years ago

Thanks for this - I like the idea and the simplicity of the terraform code.

Docs would need to be updated to reflect the additional dependency on the AWS CLI, or we'd need to implement a "smart" provider that falls back to variables if the profile doesn't exist, or we'd need to include instructions on how to use the quickstart without the AWS CLI installed by commenting out the applicable provider sections.

Curious how many quickstart users have the AWS CLI installed... if many do, then this makes lots of sense; if few do, then I'd avoid it for consistency and simplicity.

Wouldn't mind getting @chrisurwin's thoughts on this.

chrisurwin commented 4 years ago

We try to keep the quickstarts as self contained as possible, people can take these as a building block and enhance them as they see fit. This isn't something I want to add at this time.