search

rancher / quickstart

381 stars 336 forks source link

AWS quick start cannot be easily completed as written #70

Closed borenstein closed 4 years ago

borenstein commented 4 years ago

The AWS quick start guide indicates that one needs to have terraform-provider-rke installed as a pre-requisite.

What it does not say is that it requires v0.14.1 of that repo, and that by installing according to the instructions from that repo's README (which says to name the executable terraform-provider-rke), Terraform will think the version is v0.0.0.

Either the quick start guide or the README for terraform-provider-rke should be updated to clarify this issue.

See this Stack Overflow Q&A.

nikkelma commented 4 years ago

Thanks for this feedback - immediate fixes will include updating docs to not point to external sources, a possible long-term solution could be providing a docker container containing all needed dependencies alongside these installation instructions.

borenstein commented 4 years ago

I like the second idea quite a lot! I actually went that route as I was troubleshooting...

On Thu, May 7, 2020, 12:23 PM Matt Nikkel notifications@github.com wrote:

Thanks for this feedback - immediate fixes will include updating docs to not point to external sources, a possible long-term solution could be providing a docker container containing all needed dependencies alongside these installation instructions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rancher/quickstart/issues/70#issuecomment-625357638, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB6BH2ECUGF6KM7UTHBAETRQLOAFANCNFSM4MZGCSYQ .

nikkelma commented 4 years ago

89 has been merged to update documentation, and the next priority is creating a docker container - which milestone should close this issue?

nikkelma commented 4 years ago

Quick follow-up @borenstein ... now that Terraform 0.13 allows pulling the rke provider from the registry, could we mark this as closed? Specifically, getting started from zero requires installing terraform then running terraform apply - no provider installation required, all thanks to 0.13.

borenstein commented 4 years ago

Yup, that renders it moot