search

rancher / rancher-cleanup

170 stars 42 forks source link

cluster-api related resources deleted #39

Closed lwabish closed 1 year ago

lwabish commented 1 year ago

My cluster has rancher installed, at the same time, I was trying cluster-api in this same cluster. Just now I decided to uninstall rancher, after running this job, I found my cluster-api related resources are all deleted.

At first I thought this occurred because duplicate resource name like cluster etc. After checking the code, I understand that this script is intended to remove all cluster-api related resources.

So is it more reasonable to add an option to let user select whether to keep cluster-api related resources?

If this feature looks ok, I'd love to implement it

lwabish commented 1 year ago

Sadly, found my istio was unintalled too...

superseb commented 1 year ago

This seems similar to #6, see https://github.com/rancher/rancher-cleanup/issues/6#issuecomment-1285476224 for a possible implementation. I'd be happy to review your PR.

lwabish commented 1 year ago

I tried adding another arg to the cleanup.sh, maybe not the best way. #42

github-actions[bot] commented 1 year ago

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.