search

rancher / rancher-docs

Rancher Documentation
https://ranchermanager.docs.rancher.com/
Apache License 2.0
60 stars 205 forks source link

[Rancher2] Cert Manager installation instructions update for "installCRDs" #64

Open leodotcloud opened 2 years ago

leodotcloud commented 2 years ago

Request Summary: For cert-manager installation, the documentation requires one to install CRDS prior to installing the actual helm chart. But the cert-manager has an option to install CRDs. Can the docs be updated to use this option or is there a limitation as to why it can't be used?

Reference: https://rancher.com/docs/rancher/v2.6/en/installation/install-rancher-on-k8s/#4-install-cert-manager

jtravee commented 2 years ago

@MbolotSuse, could you review this and answer the question posed?

MbolotSuse commented 2 years ago

When I ran a set of tests for cert-manager I used the installCRDs=true option and saw no issues (see this comment for more details: https://github.com/rancher/rancher/issues/36693#issuecomment-1059621367). I also don't see a major difference between applying this separately and using the chart option (so long as both use the same version). That being said, I can't guarantee that this install method works perfectly with rancher in every situation. It might be helpful to get QA's opinion on if there are any other test cases outside of what that comment represent which we would need to run before updating the docs.

@anupama2501 Any Ideas on the above?

anupama2501 commented 2 years ago

@MbolotSuse @jtravee @leodotcloud we have a few test cases that we would need to validate especially for airgap and some upgrade scenarios. Let's hold on this until 2.6.4 goes out and we will validate these test cases to see if we can include both the options to install CRDs for the cert manager in the docs before 2.6.5 release.

jtravee commented 2 years ago

Set to be validated in 2.6.6.

btat commented 2 years ago

Moving to v2.7.0 to match milestone update for https://github.com/rancher/qa-tasks/issues/277

martyav commented 1 year ago

@anupama2501 @jtravee This issue is currently marked for 2023-Q2-2.7.x. Is this being validated for 2.7.5 -- meaning we should move forward with a PR for the upcoming release?

Never mind, it was pushed out (https://github.com/rancher/rancher-docs/issues/64#issuecomment-1577299699 below)

btat commented 1 year ago

@martyav looks like the milestone on https://github.com/rancher/qa-tasks/issues/277, which this one depends on, was removed last week not long after we talked about this one.