search

rancher / rancher-ecr-credentials

Docker container to periodically update the Credentials for an AWS Elastic Container Registry in Rancher
Apache License 2.0
21 stars 9 forks source link

send faux email address when creating registry credential #1

Closed wjimenez5271 closed 7 years ago

wjimenez5271 commented 7 years ago

send faux email address when creating registry credential + logging enhancements

cloudnautique commented 7 years ago

OK, the logging change looks good, but there are a few things:

  1. The tests fail I'm guessing because of the email change.
  2. main_test.go needs to be updated to use the mocks package from rancher not objectpartners
  3. We should cut over to trash.yml for deps management
  4. Convert this to dapper/makefile from go-skel.
  5. Add this to our Drone CI system.

All Rancher projects follow a similar pattern. You should be able to type make deps,test,build,package,release,ci etc. Releasing this based on someone elses flow is a bit painful.

Also, for future projects, please fork and merge in from your repo. We do not typically do branches in our main rancher/* projects unless its for release management.

cloudnautique commented 7 years ago

This needs the Dockerfile.dapper in the root directory from go-skel.

When its ready you should be able to: make deps make test make build make package

and it should all work.