rancher / rancher

Complete container management platform
http://rancher.com
Apache License 2.0
23.25k stars 2.95k forks source link

Node labels set when adding a RKE node can't be deleted #15825

Open kinarashah opened 5 years ago

kinarashah commented 5 years ago

Version: master 9/26

Steps to Reproduce:

Add a node to a custom cluster, add Node label dummy=yes so it gets added as --label dummy=test to the generated docker run command. Execute command on a node to add it. After the node was added, edit Node in UI, delete dummy=yes Results: Node labels changes back to dummy=yes SURE- 8087

deniseschannon commented 5 years ago

This might be the underlying cause of why you can't update roles/taints on nodes. https://github.com/rancher/rancher/issues/16703

sowmyav27 commented 5 years ago
loganhz commented 4 years ago

It also happens when add a node to a Custom Cluster using the command provided by rancher, add any label with --label

jiaqiluo commented 4 years ago

This is reproduced on master-4149ea9e955b6989dee3bc696125e4e714807b67-head and v2.4-3537-head I need to delete the node labels twice to get them really removed. See this issue for the detailed steps: https://github.com/rancher/rancher/issues/28617

This is actually an expected behavior because by default we let RKE enforce its own labels, so RKE will bring the labels back when it consolidates the nodes next time.

gizmotronic commented 1 year ago

While it is similar, this is not a duplicate of #28617. I've deleted old labels on my downstream RKE1 cluster nodes at least a dozen times to no effect. I'm using Rancher v2.6.12.

NosIreland commented 1 year ago

Is this expected behaviour? Because the labels cannot also be changed and are reverted back after node restart. Is there a warkarround or the only way is to remove the node and add it back without labels?

zivlazar0v commented 11 months ago

any news regarding the solution?