Bug: cluster yaml etcd "snapshot" setting always false

[patrick0057]

What kind of request is this (question/bug/enhancement/feature request): Bug

Steps to reproduce (least amount of steps as possible):

1. Create a new cluster of any provider type except imported.
2. Edit cluster, then edit cluster as YAML.
3. Scroll down to the etcd service section and observe that snapshot is set to false

Result: If you make any changes to the snapshot settings in the form, "snapshot" is always set to false in the YAML. This is a problem as the etcd-rolling-snapshots container will be deleted next time you make changes to the snapshot settings in the form. The only way to get the container back is to manually edit the cluster as YAML and set this to true.

Other details that may be helpful:

Environment information

• Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.2.4-v2.2.8
• Installation option (single install/HA): HA

Cluster information

• Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Custom / AWS

[alena1108]

@patrick0057 "Snapshot" has become a legacy flag when we enabled an ability to define recurring snapshots via Rancher UI - v2.2.0 - and is left around for rke cli use only:

https://github.com/rancher/types/blob/master/apis/management.cattle.io/v3/rke_types.go#L253

Starting v2.2.0, the indication of recurring snapshots being enabled, is as follows:

services: 
  etcd: 
    backup_config: 
      enabled: true
      interval_hours: 12
      retention: 6

The functionality for taking a recurring snapshots was moved to Rancher server side as we display the snapshot objects in Rancher API now. Based on the schedule, Rancher would contact RKE to take a one time local snapshot (and back it up to the s3 if the endpoint is configured), therefore you won't see etcd-rolling-snapshots container running.