search

rancher / rancher

Complete container management platform
http://rancher.com
Apache License 2.0
23.51k stars 2.98k forks source link

User able to edit and delete system-library chart in Rancher v2.3+ with useBundledSystemChart=true if upgrading from v2.2.x with customised system-library URL #27441

Open axeal opened 4 years ago

axeal commented 4 years ago

What kind of request is this (question/bug/enhancement/feature request):

Bug

Steps to reproduce (least amount of steps as possible):

Per https://github.com/rancher/rancher/issues/22889 from Rancher v2.3.0 on deletion of the system-library chart was prohibited and editing of the system-library catalog was prohibited when the useBundledSystemChart=true. This works as expected where the system library URL is https://git.rancher.io/system-charts; however, if upgrading Rancher from v2.2.x, in which a customised catalog URL was specified (per https://rancher.com/docs/rancher/v2.x/en/installation/options/local-system-charts/#b-configure-system-charts), it is still possible to edit and delete the system-library catalog, unless you edit the URL back to https://git.rancher.io/system-charts, at which point it becomes uneditable.

Environment information

gz#10299

axeal commented 4 years ago

Tested upgrading from v2.2.4 to v2.4.5 then v2.4.8, and behaviour is the same. system-library remains editable, despite useBundledSystemChart=true, until the system-library URL is set back to https://git.rancher.io/system-charts